fix: Download Tickets -> All Tickets #5856

ksraj123 · 2020-12-01T20:32:28Z

Changes proposed in this pull request:

Download Tickets button changes to All Tickets
Icon for button changes to download icon

Please share feedback and suggestions.

vercel · 2020-12-01T20:32:34Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/iq0c0y1zr
✅ Preview: https://open-event-frontend-git-design-changes-1.eventyay.vercel.app

codecov · 2020-12-01T20:41:21Z

Codecov Report

Merging #5856 (32db327) into development (3a1e29c) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development    #5856      +/-   ##
===============================================
- Coverage        23.46%   23.42%   -0.04%     
===============================================
  Files              512      512              
  Lines             5460     5469       +9     
  Branches            63       65       +2     
===============================================
  Hits              1281     1281              
- Misses            4163     4171       +8     
- Partials            16       17       +1

Impacted Files	Coverage Δ
app/components/widgets/forms/link-field.ts	`60.00% <0.00%> (-5.22%)`	⬇️
app/mixins/event-wizard.js	`0.89% <0.00%> (ø)`
app/components/forms/orders/order-form.js	`0.00% <0.00%> (ø)`
app/routes/events/view/edit/sessions-speakers.js	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a1e29c...32db327. Read the comment docs.

mariobehling

There is a white space between the all tickets and invoice button now. Please keep the width of the button as it previously was. Thanks.

Raunaksingh100

Duplicate of #5860
I first say I am working on this issue so, why are you spaming

Plz read the contributions introduction this is open source .

cggvuhh

there is lot of space and dupliacte of #5860

and #5860 already fixed the issue

mariobehling · 2020-12-02T05:17:01Z

Please be friendly to each other and collaborate. As mentioned elsewhere if two people collaborate and contribute code to an issue together it would also count for both in a coding contest like Codeheat for example.

ksraj123 · 2020-12-02T05:59:14Z

@Raunaksingh100 The pr you mentioned was opened around 7 hours after this one. So how could this be a duplicate or spam. Also this tone of communication should not be encouraged in open source. As I already said in the issue I did not see your comment when I started working on this. If the mentors feel that this is already fixed then please feel free to close this.

ksraj123 · 2020-12-02T05:59:51Z

@mariobehling Does this look good now? I have made the spacing like it was before.

mariobehling

Yes, looks good. Thank you!

Please keep the tone of the conversation positive and friendly. We are all here to learn as well.

iamareebjamal · 2020-12-02T11:36:09Z

app/templates/orders/view.hbs

-        <div class="d-flex space-between">
-          <button class="ui labeled icon {{if this.isLoadingTickets 'loading'}} {{if this.device.isMobile 'fluid'}} button"
+        <div class="ui padded grid">
+          <button class="ui labeled icon left floated seven wide column {{if this.isLoadingTickets 'loading'}} {{if this.device.isMobile 'fluid'}} button"


Please use flexbox with different style. Your solution is not responsive

iamareebjamal

Please use flexbox as before

ksraj123 · 2020-12-02T13:32:26Z

@iamareebjamal Unfortunately, I could not reproduce the responsiveness issues. Could you please share a screenshot for that.

Here is how it looked before on mobile devices -

Here is how it looks now -

Also, I think under the hood, semantic UI grid uses flexbox only.

Please share feedback and suggestions. Thanks

iamareebjamal · 2020-12-02T13:47:03Z

Could you please share a screenshot for that

You have done it above youself. See the difference carefully

ksraj123 · 2020-12-02T14:01:00Z

@iamareebjamal Restored flexbox , now the space between the buttons not there on mobile if that was the resposivness issue we were talking about. Please have a look. Thanks

iamareebjamal · 2020-12-02T14:14:38Z

Not equal

Remove justify stretch and set flex: 1 to both elements

ksraj123 · 2020-12-02T14:23:43Z

@iamareebjamal Oh, Thanks. Buttons made equal now.

Should I squash my commits?

iamareebjamal · 2020-12-02T15:43:03Z

Thanks for the contribution

changes to ticket download page

74f49f4

vercel bot deployed to Preview December 1, 2020 20:32 View deployment

mariobehling requested changes Dec 1, 2020

View reviewed changes

Raunaksingh100 reviewed Dec 2, 2020

View reviewed changes

cggvuhh suggested changes Dec 2, 2020

View reviewed changes

fixed spacing issue

08c7ddf

vercel bot deployed to Preview December 2, 2020 05:55 View deployment

mariobehling previously approved these changes Dec 2, 2020

View reviewed changes

iamareebjamal reviewed Dec 2, 2020

View reviewed changes

iamareebjamal requested changes Dec 2, 2020

View reviewed changes

flexbox restored

b51cdfa

ksraj123 dismissed mariobehling’s stale review via b51cdfa December 2, 2020 13:58

vercel bot deployed to Preview December 2, 2020 13:58 View deployment

buttons made equal

32db327

vercel bot deployed to Preview December 2, 2020 14:22 View deployment

iamareebjamal approved these changes Dec 2, 2020

View reviewed changes

iamareebjamal changed the title ~~changes to ticket download page~~ fix: Download Tickets -> All Tickets Dec 2, 2020

auto-label bot added the fix label Dec 2, 2020

iamareebjamal merged commit 95d739e into fossasia:development Dec 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Download Tickets -> All Tickets #5856

fix: Download Tickets -> All Tickets #5856

ksraj123 commented Dec 1, 2020 •

edited

Loading

vercel bot commented Dec 1, 2020 •

edited

Loading

codecov bot commented Dec 1, 2020 •

edited

Loading

mariobehling left a comment

Raunaksingh100 left a comment •

edited

Loading

cggvuhh left a comment •

edited

Loading

mariobehling commented Dec 2, 2020

ksraj123 commented Dec 2, 2020

ksraj123 commented Dec 2, 2020

mariobehling left a comment

iamareebjamal Dec 2, 2020

iamareebjamal left a comment

ksraj123 commented Dec 2, 2020

iamareebjamal commented Dec 2, 2020

ksraj123 commented Dec 2, 2020 •

edited

Loading

iamareebjamal commented Dec 2, 2020

ksraj123 commented Dec 2, 2020 •

edited

Loading

iamareebjamal commented Dec 2, 2020

fix: Download Tickets -> All Tickets #5856

fix: Download Tickets -> All Tickets #5856

Conversation

ksraj123 commented Dec 1, 2020 • edited Loading

Changes proposed in this pull request:

vercel bot commented Dec 1, 2020 • edited Loading

codecov bot commented Dec 1, 2020 • edited Loading

Codecov Report

mariobehling left a comment

Choose a reason for hiding this comment

Raunaksingh100 left a comment • edited Loading

Choose a reason for hiding this comment

cggvuhh left a comment • edited Loading

Choose a reason for hiding this comment

mariobehling commented Dec 2, 2020

ksraj123 commented Dec 2, 2020

ksraj123 commented Dec 2, 2020

mariobehling left a comment

Choose a reason for hiding this comment

iamareebjamal Dec 2, 2020

Choose a reason for hiding this comment

iamareebjamal left a comment

Choose a reason for hiding this comment

ksraj123 commented Dec 2, 2020

iamareebjamal commented Dec 2, 2020

ksraj123 commented Dec 2, 2020 • edited Loading

iamareebjamal commented Dec 2, 2020

ksraj123 commented Dec 2, 2020 • edited Loading

iamareebjamal commented Dec 2, 2020

ksraj123 commented Dec 1, 2020 •

edited

Loading

vercel bot commented Dec 1, 2020 •

edited

Loading

codecov bot commented Dec 1, 2020 •

edited

Loading

Raunaksingh100 left a comment •

edited

Loading

cggvuhh left a comment •

edited

Loading

ksraj123 commented Dec 2, 2020 •

edited

Loading

ksraj123 commented Dec 2, 2020 •

edited

Loading